Test timer integration, add worker shutdown #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Mar 1, 2021
Member
Sushisource
left a comment
Sushisource
left a comment
There was a problem hiding this comment.
Looking good! Glad this came together as expected.
| } | ||
| } | ||
|
|
||
| fn worker_shutdown(mut cx: FunctionContext) -> JsResult<JsUndefined> { |
Member
There was a problem hiding this comment.
Doesn't need to be this PR but you'll probably want to have some mechanism to drain any remaining activations from poll_task until it returns CoreError::ShuttingDown. Remaining activations may exist due to replaying a workflow to catch up to the end of history which was already fetched from the server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the CI does not run integration tests yet.
The tests pass on my laptop.
I have another PR (#15) which is supposed to make them run but I'm having some trouble waiting for the Temporal server to start.